github-actions[bot]
commented
3 months ago Lint Status
The following issues have been found with 34753-v1_RISCV_Implement_SATSUB_for_unsigned_scalar_int-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
=== ERROR type #1: dot, space, space, end of comment (6 error(s)) ===
gcc/config/riscv/riscv.cc:11517:26: /* Step-1: minus = x - y */
gcc/config/riscv/riscv.cc:11520:23: /* Step-2: lt = x < y */
gcc/config/riscv/riscv.cc:11523:21: /* Step-3: lt = -lt */
gcc/config/riscv/riscv.cc:11526:21: /* Step-4: lt = ~lt */
gcc/config/riscv/riscv.cc:11529:36: /* Step-5: pmode_dest = minus & lt */
gcc/config/riscv/riscv.cc:11532:30: /* Step-6: dest = pmode_dest */
=== ERROR type #2: dot, space, space, new sentence (5 error(s)) ===
gcc/config/riscv/riscv.cc:11501:5: 1.█minus = x - y.
gcc/config/riscv/riscv.cc:11502:5: 2.█lt = x < y.
gcc/config/riscv/riscv.cc:11503:5: 3.█lt = -lt.
gcc/config/riscv/riscv.cc:11504:5: 4.█lt = ~lt.
gcc/config/riscv/riscv.cc:11505:5: 5.█z = minus & lt. */
=== ERROR type #3: there should be exactly one space between function name and parenthesis (1 error(s)) ===
gcc/config/riscv/riscv.cc:11499:14: z = SAT_SUB(x, y).
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/9503388159
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=34753 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240605111630.1176001-1-pan2.li@intel.com/ Patch id: 91541
Build Targets
multilib, please refer to the table below to see all the targets within that multilib.-marchstringrv32gc-ilp32d,rv64gc-lp64drv64gcv-lp64drv32gcv-ilp32d,rv64gcv-lp64dTarget Information
-marchstringgc_zba_zbb_zbc_zbsNotes
Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist. Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours. If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com