github-actions[bot]
commented
4 months ago Lint Status
The following issues have been found with 35713-tobecommittedRISCV_DCE_analysis_for_extension_elimination-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
=== ERROR type #1: braces should be on a separate line (2 error(s)) ===
gcc/ext-dce.cc:877:43:static bool ext_dce_rd_confluence_n (edge) { return true; }
gcc/ext-dce.cc:928:33: virtual bool gate (function *) { return optimize > 0; }
=== ERROR type #2: dot, space, space, end of comment (11 error(s)) ===
gcc/ext-dce.cc:48:26: bit 32..BITS_PER_WORD-1 */
gcc/ext-dce.cc:83:20: which are safe.███*/
gcc/ext-dce.cc:909:19: RTL_PASS, /* type */
gcc/ext-dce.cc:910:20: "ext_dce", /* name */
gcc/ext-dce.cc:911:33: OPTGROUP_NONE, /* optinfo_flags */
gcc/ext-dce.cc:912:19: TV_NONE, /* tv_id */
gcc/ext-dce.cc:913:40: PROP_cfglayout, /* properties_required */
gcc/ext-dce.cc:914:27: 0, /* properties_provided */
gcc/ext-dce.cc:915:28: 0, /* properties_destroyed */
gcc/ext-dce.cc:916:24: 0, /* todo_flags_start */
gcc/ext-dce.cc:917:38: TODO_df_finish, /* todo_flags_finish */
=== ERROR type #3: dot, space, space, new sentence (1 error(s)) ===
gcc/ext-dce.cc:373:37: binop_implies_op2_fully_live (e.g.█shifts), the computed mask may
=== ERROR type #4: lines should not exceed 80 characters (5 error(s)) ===
gcc/ext-dce.cc:185:80: if (!is_a <scalar_int_mode> (GET_MODE (SUBREG_REG (x)), &outer_mode)
gcc/ext-dce.cc:221:80: if (!is_a <scalar_int_mode> (GET_MODE (SUBREG_REG (x)), &outer_mode)
gcc/ext-dce.cc:642:80: iterator to look at the sub-rtxs outside the SET context. */
gcc/ext-dce.cc:738:80: ext_dce_process_uses (insn, CALL_INSN_FUNCTION_USAGE (insn), live_tmp);
gcc/common.opt:3851:80:Perform dead code elimination on zero and sign extensions with special dataflow analysis.
=== ERROR type #5: there should be exactly one space between function name and parenthesis (5 error(s)) ===
gcc/ext-dce.cc:45:14: bit 0..7 (least significant byte)
gcc/ext-dce.cc:46:14: bit 8..15 (second least significant byte)
gcc/ext-dce.cc:520:14: register(s).
gcc/ext-dce.cc:760:33: for (rtx_insn *insn = get_insns(); insn; insn = NEXT_INSN (insn))
gcc/common.opt:3850:10:Common Var(flag_ext_dce, 1) Optimization Init(0)
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/9727158885
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=35713 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/5c2275f0-af2c-438d-87b3-bdbd76e81632@gmail.com/ Patch id: 93074
Build Targets
multilib, please refer to the table below to see all the targets within that multilib.-marchstringrv32gc-ilp32d,rv64gc-lp64drv64gcv-lp64drv32gcv-ilp32d,rv64gcv-lp64dTarget Information
-marchstringgc_zba_zbb_zbc_zbsNotes
Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist. Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours. If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com