Closed github-actions[bot] closed 1 day ago
The following issues have been found with 35847-RISCV_Add_basic_support_for_the_Zacas_extension-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
=== ERROR type #1: dot, space, space, end of comment (1 error(s)) ===
gcc/config.in:644:56:/* Define if the assembler understands -march=rv*_zacas.█*/
=== ERROR type #2: lines should not exceed 80 characters (6 error(s)) ===
gcc/config/riscv/sync.md:548:80: operands[5] = GEN_INT (riscv_union_memmodels (model_success, model_failure));
gcc/config/riscv/sync.md:617:80: operands[5] = GEN_INT (riscv_union_memmodels (model_success, model_failure));
gcc/config/riscv/sync.md:632:80: "(TARGET_ZALRSC && TARGET_INLINE_SUBWORD_ATOMIC) || (TARGET_ZACAS && TARGET_ZABHA)"
gcc/configure:30889:80: { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -march=rv32i_zacas support" >&5
gcc/configure:30897:80: if { ac_try='$gcc_cv_as $gcc_cv_as_flags -march=rv32i_zacas -o conftest.o conftest.s >&5'
gcc/configure:30912:80:{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_riscv_march_zacas" >&5
=== ERROR type #3: there should be exactly one space between function name and parenthesis (3 error(s)) ===
gcc/config/riscv/riscv.opt:267:4:Mask(ZACAS) Var(riscv_za_subext)
gcc/configure.ac:5467:25: gcc_GAS_CHECK_FEATURE([-march=rv32i_zacas support],
gcc/configure.ac:5470:16: [AC_DEFINE(HAVE_AS_MARCH_ZACAS, 1,
=== ERROR type #4: trailing operator (1 error(s)) ===
gcc/configure:30900:13: ac_status=$?
Target | Status |
---|---|
Baseline hash: https://github.com/gcc-mirror/gcc/commit/038d64f62271ddc62aa35d0a5dfd3843fdb9e6d7 | Failed |
Tip of tree hash: https://github.com/gcc-mirror/gcc/commit/ad2206d576603c94b0c1778c84b7f43fbf8a13b4 | Applied |
git log --oneline from the most recently applied patch to the baseline
> git log --oneline ad2206d576603c94b0c1778c84b7f43fbf8a13b4^..HEAD
65d68ac837a RISC-V: Add basic support for the Zacas extension
ad2206d5766 Revert "Delete MALLOC_ABI_ALIGNMENT define from pa32-linux.h"
Failed to apply to the post-commit baseline. This can happen if your commit requires a recently-commited patch in order to apply. The pre-commit CI will only perform a build since it doesn't know what dejagnu testsuite failures are expected on the tip-of-tree.
If you would like us to re-run this patch once the baseline reaches a different hash, please email us at patchworks-ci@rivosinc.com with a link to your patch.
Target | Status |
---|---|
newlib-rv32imc_zba_zbb_zbc_zbs-ilp32d-non-multilib | Success |
linux-rv64gcv-lp64d-multilib | Success |
newlib-rv64gcv-lp64d-multilib | Success |
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib | Success |
newlib-rv64gc-lp64d-multilib | Success |
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib | Success |
Patch(es) were applied to the hash https://github.com/gcc-mirror/gcc/commit/ad2206d576603c94b0c1778c84b7f43fbf8a13b4. If this patch commit depends on or conflicts with a recently committed patch, then these results may be outdated.
Testsuite tests were skipped. Patch did not apply to baseline hash https://github.com/gcc-mirror/gcc/commit/038d64f62271ddc62aa35d0a5dfd3843fdb9e6d7. No comparison applicable.
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/9783203198
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=35847 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240703181600.268160-1-patrick@rivosinc.com/ Patch id: 93308
Build Targets
multilib
, please refer to the table below to see all the targets within that multilib.-march
stringrv32gc-ilp32d
,rv64gc-lp64d
rv64gcv-lp64d
rv32gcv-ilp32d
,rv64gcv-lp64d
Target Information
-march
stringgc_zba_zbb_zbc_zbs
Notes
Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist. Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours. If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com