github-actions[bot]
commented
1 month ago Lint Status
The following issues have been found with 36989-v2_RISCV_Add_withcmodel_configure_option-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
=== ERROR type #1: blocks of 8 spaces should be replaced with tabs (1 error(s)) ===
gcc/configure:1884:15: --with-cmodel████████ Code model configuration string (RISC-V only)
=== ERROR type #2: dot, space, space, new sentence (2 error(s)) ===
gcc/doc/invoke.texi:31288:52:between absolute addresses @minus{}2 GiB and +2 GiB.█Programs can be statically
gcc/doc/invoke.texi:31289:22:or dynamically linked.█This is the default code model unless GCC has been
=== ERROR type #3: lines should not exceed 80 characters (6 error(s)) ===
gcc/config.gcc:4726:80: supported_defaults="abi arch tune riscv_attribute isa_spec tls cmodel"
gcc/config.gcc:4885:80: # Make sure --with-cmodel is valid. If it was not specified,
gcc/config.gcc:4891:80: echo "invalid option for --with-cmodel: '${with_cmodel}', available values are 'medlow' 'medany' 'large'" 1>&2
gcc/config.gcc:4895:80: tm_defines="${tm_defines} TARGET_RISCV_DEFAULT_CMODEL=${with_cmodel}"
gcc/config.gcc:6089:80:all_defaults="abi cpu cpu_32 cpu_64 arch arch_32 arch_64 tune tune_32 tune_64 schedule float mode fpu nan fp_32 odd_spreg_32 divide llsc mips-plt synci tls lxc1-sxc1 madd4 isa_spec compact-branches msa cmodel"
gcc/configure.ac:1216:80:[AS_HELP_STRING([--with-cmodel], [Code model configuration string (RISC-V only)])],
=== ERROR type #4: there should be exactly one space between function name and parenthesis (2 error(s)) ===
gcc/configure.ac:1215:11:AC_ARG_WITH(cmodel,
gcc/configure.ac:1216:15:[AS_HELP_STRING([--with-cmodel], [Code model configuration string (RISC-V only)])],
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/10210454299
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=36989 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240802051151.3658614-1-hau.hsu@sifive.com/ Patch id: 95144
Build Targets
multilib, please refer to the table below to see all the targets within that multilib.-marchstringrv64gcv-lp64d,rv32gc-ilp32d,rv64gc-lp64d,rv32imc_zba_zbb_zbc_zbs-ilp32rv32gcv-ilp32d,rv64gcv-lp64drv32gc_zba_zbb_zbc_zbs-ilp32d,rv64gc_zba_zbb_zbc_zbs-lp64dTarget Information
-marchstringgc_zba_zbb_zbc_zbsNotes
Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist. Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours. If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com