github-actions[bot]
commented
2 months ago Lint Status
The following issues have been found with 37935-v1_RISCV_Support_form_1_of_integer_scalar_SATADD-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
=== ERROR type #1: dot, space, space, end of comment (5 error(s)) ===
gcc/config/riscv/riscv.cc:11989:18: 15. z = z | max */
gcc/config/riscv/riscv.cc:12021:34: /* Step-3: lt = x < 0, neg = -lt */
gcc/config/riscv/riscv.cc:12025:72: /* Step-4: max = 0x7f..., max = max ^ neg, neg = -and, max = max & neg */
gcc/config/riscv/riscv.cc:12031:44: /* Step-5: and = and - 1, dest = sum & and */
gcc/config/riscv/riscv.cc:12035:67: /* Step-6: xmode_dest = xmode_dest | xmode_max, dest = xmode_dest */
=== ERROR type #2: dot, space, space, new sentence (6 error(s)) ===
gcc/config/riscv/riscv.cc:11984:6: 10.█max = max ^ neg
gcc/config/riscv/riscv.cc:11985:6: 11.█neg = -and
gcc/config/riscv/riscv.cc:11986:6: 12.█max = max & neg
gcc/config/riscv/riscv.cc:11987:6: 13.█and = and - 1
gcc/config/riscv/riscv.cc:11988:6: 14.█z = sum & and
gcc/config/riscv/riscv.cc:11989:6: 15.█z = z | max */
=== ERROR type #3: there should be exactly one space between function name and parenthesis (1 error(s)) ===
gcc/config/riscv/riscv.cc:11973:14: z = SAT_ADD(x, y).
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/10609920719
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=37935 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240829062542.3451179-1-pan2.li@intel.com/ Patch id: 96647
Build Targets
multilib, please refer to the table below to see all the targets within that multilib.-marchstringrv64gcv-lp64d,rv32gc-ilp32d,rv64gc-lp64d,rv32imc_zba_zbb_zbc_zbs-ilp32rv32gcv-ilp32d,rv64gcv-lp64drv32gc_zba_zbb_zbc_zbs-ilp32d,rv64gc_zba_zbb_zbc_zbs-lp64dTarget Information
-marchstringgc_zba_zbb_zbc_zbsNotes
Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist. Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours. If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com