github-actions[bot]
commented
12 months ago Lint Status
The following issues have been found with 26034-RISCV_Add_AVL_propagation_PASS_for_RVV_autovectorization-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch. If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.
=== ERROR type #1: braces should be on a separate line (1 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:104:77: pass_avlprop (gcc::context *ctxt) : rtl_opt_pass (pass_data_avlprop, ctxt) {}
=== ERROR type #2: dot, space, space, end of comment (12 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:90:20: RTL_PASS, /* type */
gcc/config/riscv/riscv-avlprop.cc:91:21: "avlprop", /* name */
gcc/config/riscv/riscv-avlprop.cc:92:33: OPTGROUP_NONE, /* optinfo_flags */
gcc/config/riscv/riscv-avlprop.cc:93:20: TV_NONE, /* tv_id */
gcc/config/riscv/riscv-avlprop.cc:94:29: 0, /* properties_required */
gcc/config/riscv/riscv-avlprop.cc:95:29: 0, /* properties_provided */
gcc/config/riscv/riscv-avlprop.cc:96:30: 0, /* properties_destroyed */
gcc/config/riscv/riscv-avlprop.cc:97:26: 0, /* todo_flags_start */
gcc/config/riscv/riscv-avlprop.cc:98:27: 0, /* todo_flags_finish */
gcc/config/riscv/riscv-avlprop.cc:282:77: /* Go through all the instructions looking for AVL that we could propagate.█*/
gcc/config/riscv/riscv-v.cc:4451:77: to emit vsetvl. We pick up the default value according to prefer policy.█*/
gcc/config/riscv/riscv-v.cc:4497:43: all RVV instructions that have VTYPE OP.█*/
=== ERROR type #3: dot, space, space, new sentence (7 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:26:49: there will become even harder to maintain.█A straight forward
gcc/config/riscv/riscv-avlprop.cc:167:34: arithmetic operations (e.d.█DIV), then do the whole vector register
gcc/config/riscv/riscv-avlprop.cc:173:65: generates the VLMAX instruction due to missed LEN information.█The later
gcc/config/riscv/riscv-avlprop.cc:198:18: instruction.█It should be totally enough for vectorized codes since
gcc/config/riscv/riscv-v.cc:4451:20: to emit vsetvl.█We pick up the default value according to prefer policy. */
gcc/config/riscv/riscv-v.cc:4488:38:/* Helper function to get SEW operand.█We always have SEW value for
gcc/config/riscv/riscv-v.cc:4496:40:/* Helper function to get VLMUL operand.█We always have VLMUL value for
=== ERROR type #4: lines should not exceed 80 characters (1 error(s)) ===
gcc/config.gcc:547:80: extra_objs="${extra_objs} riscv-v.o riscv-vsetvl.o riscv-vector-costs.o riscv-avlprop.o"
=== ERROR type #5: there should be exactly one space between function name and parenthesis (1 error(s)) ===
gcc/config/riscv/riscv-avlprop.cc:9:50:the Free Software Foundation; either version 3, or(at your option)
=== ERROR type #6: trailing whitespace (1 error(s)) ===
gcc/config/riscv/t-riscv:74:65: $(TARGET_H) tree-pass.h df.h rtl-ssa.h cfgcleanup.h insn-attr.h█
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/6622136375
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=26034 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20231024033200.224558-1-juzhe.zhong@rivai.ai/
Notes
Testsuite checks are in beta testing stages. Results are unstable and may be inaccurate.