github-actions[bot]
commented
11 months ago Lint Status
The following issues have been found with 25849-Refactor_and_cleanup_vsetvl_pass-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch. If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.
=== ERROR type #1: braces should be on a separate line (20 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:1693:49: vsetvl_info (insn_info *insn) : vsetvl_info () { parse_insn (insn); }
gcc/config/riscv/riscv-vsetvl.cc:1695:48: vsetvl_info (rtx_insn *insn) : vsetvl_info () { parse_insn (insn); }
gcc/config/riscv/riscv-vsetvl.cc:1697:25: void set_avl (rtx avl) { m_avl = avl; }
gcc/config/riscv/riscv-vsetvl.cc:1698:23: void set_vl (rtx vl) { m_vl = vl; }
gcc/config/riscv/riscv-vsetvl.cc:1699:39: void set_avl_def (set_info *avl_def) { m_avl_def = avl_def; }
gcc/config/riscv/riscv-vsetvl.cc:1700:29: void set_sew (uint8_t sew) { m_sew = sew; }
gcc/config/riscv/riscv-vsetvl.cc:1701:36: void set_vlmul (vlmul_type vlmul) { m_vlmul = vlmul; }
gcc/config/riscv/riscv-vsetvl.cc:1702:33: void set_ratio (uint8_t ratio) { m_ratio = ratio; }
gcc/config/riscv/riscv-vsetvl.cc:1703:24: void set_ta (bool ta) { m_ta = ta; }
gcc/config/riscv/riscv-vsetvl.cc:1704:24: void set_ma (bool ma) { m_ma = ma; }
gcc/config/riscv/riscv-vsetvl.cc:1705:21: void set_delete () { m_delete = true; }
gcc/config/riscv/riscv-vsetvl.cc:1706:28: void set_bb (bb_info *bb) { m_bb = bb; }
gcc/config/riscv/riscv-vsetvl.cc:1707:37: void set_max_sew (uint8_t max_sew) { m_max_sew = max_sew; }
gcc/config/riscv/riscv-vsetvl.cc:1708:32: void set_change_vtype_only () { m_change_vtype_only = true; }
gcc/config/riscv/riscv-vsetvl.cc:1709:42: void set_read_vl_insn (insn_info *insn) { m_read_vl_insn = insn; }
gcc/config/riscv/riscv-vsetvl.cc:1773:20: void set_valid () { m_state = state_type::VALID; }
gcc/config/riscv/riscv-vsetvl.cc:1774:22: void set_unknown () { m_state = state_type::UNKNOWN; }
gcc/config/riscv/riscv-vsetvl.cc:1775:20: void set_empty () { m_state = state_type::EMPTY; }
gcc/config/riscv/riscv-vsetvl.cc:1785:47: void set_avl_demand (avl_demand_type demand) { m_avl_demand = demand; }
gcc/config/riscv/riscv-vsetvl.cc:2206:25: void set_empty_info () { m_info.set_empty (); }
=== ERROR type #2: dot, space, space, end of comment (3 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:1740:66: /* The VL operand can only be either a NULL_RTX or a register.███*/
gcc/config/riscv/riscv-vsetvl.cc:1896:22: /* uninitialized */
gcc/config/riscv/riscv-vsetvl.cc:2048:31: insert vsetvl correctly.*/
=== ERROR type #3: dot, space, space, new sentence (7 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:1585:19: RVV instruction.█For example, DEMAND_RATIO_P indicates that this RVV
gcc/config/riscv/riscv-vsetvl.cc:1609:52:/* We split the demand information into three parts.█They are sew and lmul
gcc/config/riscv/riscv-vsetvl.cc:1612:52: interfaces avaiable_with, compatible_p and merge.█avaiable_with is
gcc/config/riscv/riscv-vsetvl.cc:1614:20: available or not.█If prev_info is available for next_info, it means that the
gcc/config/riscv/riscv-vsetvl.cc:1616:63: can be used without inserting a separate vsetvl instruction.█compatible_p
gcc/config/riscv/riscv-vsetvl.cc:1915:32: doesn't care about ratio.█However, we still need this value
gcc/config/riscv/riscv-vsetvl.cc:1947:26: DEMAND_AVL_P for now.█it may be corrected to
=== ERROR type #4: there should be exactly one space between function name and parenthesis (1 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:2001:32: /* Determine if dest operand(vl) has been used by non-RVV instructions. */
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/6777873622
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=25849 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20231019083333.2052340-2-lehua.ding@rivai.ai/
Build Targets
multilib, please refer to the table below to see all the targets within that multilib.-marchstringrv32gc-ilp32d,rv64gc-lp64drv32gcv-ilp32d,rv64gcv-lp64dTarget Information
-marchstringgc_zba_zbb_zbc_zbsNotes
Testsuite checks are in beta testing stages. Results are unstable and may be inaccurate.