Closed github-actions[bot] closed 11 months ago
The following issues have been found with 25849-Refactor_and_cleanup_vsetvl_pass-3 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch. If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.
=== ERROR type #1: blocks of 8 spaces should be replaced with tabs (45 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:2207:23: AVAILABLE_P, FUSE)████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2208:52: if (prev_flags == sew_lmul_demand_type::PREV_FLAGS████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2209:56: && next_flags == sew_lmul_demand_type::NEXT_FLAGS)████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2223:23: AVAILABLE_P, FUSE)████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2224:52: if (prev_flags == sew_lmul_demand_type::PREV_FLAGS████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2225:56: && next_flags == sew_lmul_demand_type::NEXT_FLAGS)████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2239:23: AVAILABLE_P, FUSE)████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2240:52: if (prev_flags == sew_lmul_demand_type::PREV_FLAGS████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2241:56: && next_flags == sew_lmul_demand_type::NEXT_FLAGS)████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2242:5: {████████████████████████████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2243:45: gcc_assert (COMPATIBLE_P (prev, next));████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2244:24: FUSE (prev, next);████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2245:65: prev.set_sew_lmul_demand (sew_lmul_demand_type::NEW_FLAGS);████████ \
gcc/config/riscv/riscv-vsetvl.cc:2246:13: return;████████████████████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2260:21: AVAILABLE_P, FUSE)████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2261:50: if (prev_flags == policy_demand_type::PREV_FLAGS████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2262:54: && next_flags == policy_demand_type::NEXT_FLAGS)████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2276:21: AVAILABLE_P, FUSE)████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2277:50: if (prev_flags == policy_demand_type::PREV_FLAGS████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2278:54: && next_flags == policy_demand_type::NEXT_FLAGS)████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2292:21: AVAILABLE_P, FUSE)████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2293:50: if (prev_flags == policy_demand_type::PREV_FLAGS████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2294:54: && next_flags == policy_demand_type::NEXT_FLAGS)████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2295:5: {████████████████████████████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2296:45: gcc_assert (COMPATIBLE_P (prev, next));████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2297:24: FUSE (prev, next);████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2298:61: prev.set_policy_demand (policy_demand_type::NEW_FLAGS);████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2299:13: return;████████████████████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2312:69:#define DEF_AVL_RULE(PREV_FLAGS, NEXT_FLAGS, NEW_FLAGS, COMPATIBLE_P,████████ \
gcc/config/riscv/riscv-vsetvl.cc:2313:25: AVAILABLE_P, FUSE)████████████████████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2314:47: if (prev_flags == avl_demand_type::PREV_FLAGS████████████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2315:51: && next_flags == avl_demand_type::NEXT_FLAGS)████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2328:69:#define DEF_AVL_RULE(PREV_FLAGS, NEXT_FLAGS, NEW_FLAGS, COMPATIBLE_P,████████ \
gcc/config/riscv/riscv-vsetvl.cc:2329:25: AVAILABLE_P, FUSE)████████████████████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2330:47: if (prev_flags == avl_demand_type::PREV_FLAGS████████████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2331:51: && next_flags == avl_demand_type::NEXT_FLAGS)████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2344:69:#define DEF_AVL_RULE(PREV_FLAGS, NEXT_FLAGS, NEW_FLAGS, COMPATIBLE_P,████████ \
gcc/config/riscv/riscv-vsetvl.cc:2345:25: AVAILABLE_P, FUSE)████████████████████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2346:47: if (prev_flags == avl_demand_type::PREV_FLAGS████████████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2347:51: && next_flags == avl_demand_type::NEXT_FLAGS)████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2348:5: {████████████████████████████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2349:45: gcc_assert (COMPATIBLE_P (prev, next));████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2350:24: FUSE (prev, next);████████████████████████████████████████████████ \
gcc/config/riscv/riscv-vsetvl.cc:2351:55: prev.set_avl_demand (avl_demand_type::NEW_FLAGS);████████████████████████\
gcc/config/riscv/riscv-vsetvl.cc:2352:13: return;████████████████████████████████████████████████████████████████ \
=== ERROR type #2: braces should be on a separate line (1 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:2111:69: demand_system () : m_avl_def_in (nullptr), m_avl_def_out (nullptr) {}
=== ERROR type #3: dot, space, space, end of comment (7 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:1755:32: /* predictors for sew and lmul */
gcc/config/riscv/riscv-vsetvl.cc:1866:40: /* predictors for tail and mask policy */
gcc/config/riscv/riscv-vsetvl.cc:1884:23: /* predictors for avl */
gcc/config/riscv/riscv-vsetvl.cc:2017:14: /* modifiers */
gcc/config/riscv/riscv-vsetvl.cc:2023:31: /* modifiers for sew and lmul */
gcc/config/riscv/riscv-vsetvl.cc:2075:39: /* modifiers for tail and mask policy */
gcc/config/riscv/riscv-vsetvl.cc:2093:22: /* modifiers for avl */
=== ERROR type #4: dot, space, space, new sentence (1 error(s)) ===
gcc/config/riscv/riscv-vsetvl.cc:1727:11: e.g.█bb 2 (demand SEW = 32, LMUL = M2) -> bb 3 (demand RATIO = 16).
Target | Status |
---|---|
Baseline hash: https://github.com/gcc-mirror/gcc/commit/ff05a3e91ddac56acd23db107a9a44f246aeb8b1 | Applied |
Tip of tree hash: https://github.com/gcc-mirror/gcc/commit/56ed1055b2f40ac162ae8d382280ac07a33f789f | Applied |
Patch applied successfully
Target | Status |
---|---|
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib | Build failure. Please check the 78135-linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib-build-log artifact |
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib | Build failure. Please check the 78135-linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib-build-log artifact |
newlib-rv64gc-lp64d-multilib | Build failure. Please check the 78135-newlib-rv64gc-lp64d-multilib-build-log artifact |
linux-rv64gcv-lp64d-multilib | Build failure. Please check the 78135-linux-rv64gcv-lp64d-multilib-build-log artifact |
Patch(es) were applied to the hash https://github.com/gcc-mirror/gcc/commit/ff05a3e91ddac56acd23db107a9a44f246aeb8b1. If this patch commit depends on or conflicts with a recently committed patch, then these results may be outdated.
Build Failures | Additional Info |
---|---|
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib | Build failure. Please check the 78135-linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib-build-log artifact |
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib | Build failure. Please check the 78135-linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib-build-log artifact |
newlib-rv64gc-lp64d-multilib | Build failure. Please check the 78135-newlib-rv64gc-lp64d-multilib-build-log artifact |
linux-rv64gcv-lp64d-multilib | Build failure. Please check the 78135-linux-rv64gcv-lp64d-multilib-build-log artifact |
New Failures | gcc | g++ | gfortran | Previous Hash |
---|
Resolved Failures | gcc | g++ | gfortran | Previous Hash |
---|
Unresolved Failures | gcc | g++ | gfortran | Previous Hash |
---|
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/6777873622
Patch information
Applied patches: 1 -> 3 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=25849 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20231019083333.2052340-4-lehua.ding@rivai.ai/
Build Targets
multilib
, please refer to the table below to see all the targets within that multilib.-march
stringrv32gc-ilp32d
,rv64gc-lp64d
rv32gcv-ilp32d
,rv64gcv-lp64d
Target Information
-march
stringgc_zba_zbb_zbc_zbs
Notes
Testsuite checks are in beta testing stages. Results are unstable and may be inaccurate.