search

ewmailing / IupEmscripten

Emscripten (native web browser) backend for IUP (Portable native-GUI Interface) [switch to Emscripten branch]
Other
10 stars 1 forks source link

Symbol visibility #1

Closed cmatzenbach closed 6 years ago

cmatzenbach commented 7 years ago

I'm not sure why github thinks I added lines 31-50; I didn't, they were already there. For everthing else, added the IUP_EXPORT annotation to all lines in the discussed range, except for the functions that were labeled as deprecated in the comments.

ewmailing commented 7 years ago

I think the reason the extra lines are added is because this request is trying to commit to the mainline branch instead of the SymbolVisibility branch.

The mainline branch must remain clean because that is the branch I am using to track only official IUP updates (so it is possible to merge with all the other downstream branches).

I think we need to abort this request and try another on the correct branch. Alternatively, we can try to do this directly in Git. I still don't really understand the Github interface.

ewmailing commented 7 years ago

I see that you actually already committed into the SymbolVisibility branch and pushed it. That kind of defeats the purpose of this GitHub UI. But you did commit to the correct branch there. So I'm going to close this.

By the way, I think you missed a few functions:

/ DEPRECATED IupTree utilities, use IupAttributeId functions. It will be removed in a future version. / void IupTreeSetAttribute (Ihandle ih, const char name, int id, const char value); void IupTreeStoreAttribute(Ihandle ih, const char name, int id, const char value); char IupTreeGetAttribute (Ihandle ih, const char name, int id); int IupTreeGetInt (Ihandle ih, const char name, int id); float IupTreeGetFloat (Ihandle ih, const char name, int id); void IupTreeSetfAttribute (Ihandle ih, const char name, int id, const char* format, ...);

/ DEPRECATED callback management. It will be removed in a future version. / const char* IupGetActionName(void);

/ DEPRECATED font names. It will be removed in a future version. / char IupMapFont (const char iupfont); char IupUnMapFont (const char driverfont);

/****/ / Pre-definided dialogs / /****/

Ihandle IupFileDlg(void); Ihandle IupMessageDlg(void); Ihandle IupColorDlg(void); Ihandle IupFontDlg(void); Ihandle* IupProgressDlg(void);