Seller's `defaultOptions` gets overwritten by `merge.recursive`

ewngs / szamlazz.js

Node.js client for Szamlazz.hu

MIT License

38 stars 34 forks source link

Seller's `defaultOptions` gets overwritten by `merge.recursive` #55

Closed geiszla closed 11 months ago

geiszla commented 11 months ago

Since the merge.recursive call inside the Seller class does not have the clone option, it will not clone the input object, therefore every call of the Seller constructor will overwrite the defaultOptions with the user's options.

This also means that seller details can mix (e.g., bank account of a seller can appear on another invoice).

ert78gb commented 11 months ago

thx for reporting. I will fix it today

github-actions[bot] commented 11 months ago

:tada: This issue has been resolved in version 6.1.2 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: