Open draxvint opened 3 weeks ago
Please, don't convert it to typescript. Just simple add a type definition file with tsdjs/tsd test . thanks.
Thanks for bring the attention to the typo I will examine do we need to setup the responseEncoding
or not.
Okay, I'll do it that way. Thanks!
Hey there! π
While I started working on converting this package to TypeScript, I noticed a typo due to type checking.
Current code: https://github.com/ewngs/szamlazz.js/blob/d23703172088d22886b4acd3db90f23717df6425/lib/Client.js#L161
Correct code:
Itβs a simple fix, but just wanted to point it out. It might also need testing since axios may not be using the response encoding parameter due to this typo. Thanks for all the hard work! π