search

ewngs / szamlazz.js

Node.js client for Szamlazz.hu
MIT License
41 stars 35 forks source link

Typo in axiosOptions: reponseEncoding should be responseEncoding #75

Open draxvint opened 3 weeks ago

draxvint commented 3 weeks ago

Hey there! 😊

While I started working on converting this package to TypeScript, I noticed a typo due to type checking.

Current code: https://github.com/ewngs/szamlazz.js/blob/d23703172088d22886b4acd3db90f23717df6425/lib/Client.js#L161

Correct code:

axiosOptions.responseEncoding = 'binary'

It’s a simple fix, but just wanted to point it out. It might also need testing since axios may not be using the response encoding parameter due to this typo. Thanks for all the hard work! 👍

ert78gb commented 2 weeks ago

Please, don't convert it to typescript. Just simple add a type definition file with tsdjs/tsd test . thanks.

Thanks for bring the attention to the typo I will examine do we need to setup the responseEncoding or not.

draxvint commented 2 weeks ago

Okay, I'll do it that way. Thanks!