ewojtach / node-red-contrib-firebase-storage

NodeRED nodes allowing to interact with Firebase storage
Apache License 2.0
2 stars 1 forks source link

Build failed with Node-RED 2.1.x / Node 14.18.x #12

Open novalu opened 2 years ago

novalu commented 2 years ago

Hello, I was using your library with Node-RED 0.x and 1.x until I upgraded to Node-RED 2.x. It looks like library (and probably firebase dependency is not compatible with this version (or underlying Node.js 14.x). I see that this library uses firebase version 5.x (last updated in 2019). Could you please look if it's possible to upgrade? Log from the library install is below. Thank you for your work!

2021-11-06T15:11:56.895Z [out]   CXX(target) Release/obj.target/grpc/deps/grpc/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.o
2021-11-06T15:11:59.027Z [err] ../deps/grpc/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc: In function ‘grpc_grpclb_request* grpc_grpclb_request_create(const char*)’:
2021-11-06T15:11:59.027Z [err] ../deps/grpc/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc:70:10: error: ‘char* strncpy(char*, const char*, size_t)’ specified bound 128 equals destination size [-Werror=stringop-truncation]
2021-11-06T15:11:59.027Z [err]    strncpy(req->initial_request.name, lb_service_name,
2021-11-06T15:11:59.027Z [err]    ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-11-06T15:11:59.027Z [err]            GRPC_GRPCLB_SERVICE_NAME_MAX_LENGTH);
2021-11-06T15:11:59.027Z [err]            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-11-06T15:11:59.437Z [err] cc1plus: all warnings being treated as errors
2021-11-06T15:11:59.460Z [err] make: *** [grpc.target.mk:494: Release/obj.target/grpc/deps/grpc/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.o] Chyba 1