search

ewolff / microservice-kafka

Demo to show how Apache Kafka can be used for communication between microservices
Apache License 2.0
584 stars 302 forks source link

Request without post or get #18

Closed akondasif closed 4 years ago

akondasif commented 4 years ago

Hi @ewolff ,

We followed your recommendations from this issue and found a few instances of request method without get or post

Source:

https://github.com/ewolff/microservice-kafka/blob/918d5387daa7242f0b1a741c7d772142093a0ceb/microservice-kafka/microservice-kafka-shipping/src/main/java/com/ewolff/microservice/shipping/web/ShippingController.java#L28

and

https://github.com/ewolff/microservice-kafka/blob/918d5387daa7242f0b1a741c7d772142093a0ceb/microservice-kafka/microservice-kafka-order/src/main/java/com/ewolff/microservice/order/logic/OrderController.java#L45

and

https://github.com/ewolff/microservice-kafka/blob/918d5387daa7242f0b1a741c7d772142093a0ceb/microservice-kafka/microservice-kafka-invoicing/src/main/java/com/ewolff/microservice/invoicing/web/InvoiceController.java#L28

ewolff commented 4 years ago

As mentioned https://github.com/ewolff/microservice/issues/28#issuecomment-654375293 I don't think this is a security problem. Please reopen if you have different information. Thanks.

ewolff commented 4 years ago

Actually you are right. Sorry.

akondasif commented 4 years ago

No need to apologize. Thanks for the feedback.