search

eworm-de / mkinitcpio-ykfde

Full disk encryption with Yubikey (Yubico key)
GNU General Public License v3.0
109 stars 26 forks source link

[FEATURE REQUEST] Prompt for second factors instead of getting them on the command line #8

Closed guiniol closed 8 years ago

guiniol commented 8 years ago

I don't really like having to type the 2FA on the command line, and would much rather have a prompt like when it asks for the encryption key (ie, where the password is not echoed). I don't know if this is in the works, but if it isn't I'll take a look and try to add it myself, if that's ok.

eworm-de commented 8 years ago

This is on my TODO list, but I did not work on it, yet.

guiniol commented 8 years ago

Ok. I'll see what I can do then.

eworm-de commented 8 years ago

Implemented with 49200cf2e80f7d23d2a2717130486316a9e12698. Want to give it a try?

guiniol commented 8 years ago

That was fast! Works well here. I would suggest a confirmation for the new second factor and when using -S for the first time.

eworm-de commented 8 years ago

I would suggest a confirmation for the new second factor

Done in 631b93a7d056b1d73b14993cd13c5bdc3b1785a6. Want to give it a try?

and when using -S for the first time.

When parsing the command line I do not know whether or not this is the initialization. In 1c02924892b0ee0e325677351667bad799b7a254 I changed the documentation to use -n for initialization. -s (and -S without verification) still works, though.

guiniol commented 8 years ago

That makes sense: -n is the new value of 2fa, and -s is only needed if there is already a 2fa. I'll try it Friday (no access to the computer until then).

guiniol commented 8 years ago

Works here. Nice!

eworm-de commented 8 years ago

Thanks for testing!