search

eworm-de / mpd-notification

Notify about tracks played by mpd
GNU General Public License v3.0
86 stars 23 forks source link

Feature request: command line flag to hide change notification title "MPD Notification" #10

Closed pkillnine closed 8 years ago

pkillnine commented 8 years ago

I prefer it without a title, so currently I set the title to "" by changing line 19 in config.def.h to #define TEXT_TOPIC "" but it would be nice to be able to disable it via the command line without having to recompile it. I don't know C though so I can't add this.

eworm-de commented 8 years ago

This does not work for me. When I define TEXT_TOPIC to "" (empty string) or NULL I get:

(process:31928): libnotify-CRITICAL **: notify_notification_update: assertion 'summary != NULL && *summary != '\0'' failed

Possibly this was added with later versions of libnotify, but notifications without topic are not supposed to work.

Ashe commented 5 years ago

Sorry to necro this, but I do think this would make a great addition. Instead of providing no topic, how about putting "Playing " there instead? It is really ugly having MPD notification all the time, the first thing you want to see is the song name after all! :)

Roboron3042 commented 3 years ago

I tried changing the default topic to show song title, but formatting was all over the place (not only <b, but also quotes). And I don't have the slightest idea how to fix it. imagen

So, instead I went with @Ashe suggestion and just replaced the default topic with the state only. Not what I'd like the most, but still better than before.

imagen

I'll open a PR.