search

eworm-de / mpd-notification

Notify about tracks played by mpd
GNU General Public License v3.0
86 stars 23 forks source link

music-dir not required anymore #27

Closed Dankr4d closed 5 years ago

Dankr4d commented 5 years ago

The music-dir configuration option for reading the album art out of files isn't required anymore since mpd added the albumart to there protocol (https://github.com/MusicPlayerDaemon/MPD/pull/86). Documentation can also be found here: https://www.musicpd.org/doc/html/protocol.html#the-music-database

eworm-de commented 5 years ago

But mpd can read image data from plain image file cover.{png,jpg,tiff,bmp} only, no? Note we can read embedded data from media files... So I would prefer to keep our feature. Or did I miss any details?

Dankr4d commented 5 years ago

I opened this issue quite to early. I've seen now, that this feature only supports loading files with the filename “cover” with any of “.png, .jpg, .tiff, .bmp” extensions. That's realy bad. I think this issue could be closed. Sorry ;)

eworm-de commented 5 years ago

Thanks anyway. Please open another issue if mpd supports what we need.

Nemo157 commented 3 years ago

Since 0.22 MPD now supports reading embedded images too: https://www.musicpd.org/doc/html/protocol.html#command-readpicture

eworm-de commented 3 years ago

Ah, nice... Still libmpdclient does not (yet?) support this, no? Will have to take a detailed look.

Nemo157 commented 3 years ago

Correct, it sounds like there is an implementation for it that will hopefully be PRed soon https://github.com/MusicPlayerDaemon/libmpdclient/issues/21.

eworm-de commented 3 years ago

Subscribed... Thanks for the link.