eworm-de / mpd-notification

Notify about tracks played by mpd
GNU General Public License v3.0
86 stars 23 forks source link

Cover art not working #45

Closed Fxzzi closed 4 months ago

Fxzzi commented 5 months ago

music-dir has been set correctly and mpd-notification can correctly find my music files:

~ $ mpd-notification -v                                        
mpd-notification: mpd-notification v0.8.7 +systemd +libav (compiled: May 19 2024, 18:36:54)
mpd-notification: MIME type for /home/faaris/Music//Sullivan King/Someone Else/01 Someone Else.m4a is: audio/x-m4a
mpd-notification: Playing <b>Someone Else</b> by <i>Sullivan King</i> from <i>Someone Else</i>

Is this due to my music being in the m4a format? I am using dunst, and I have also attempted to use the notification-file to no avail, it just shows a generic music file icon.

eworm-de commented 5 months ago

Probably, yes. Does it work if you comment these two lines? https://github.com/eworm-de/mpd-notification/blob/e167b84f164904fcc14498a27026b5a354a5d0ad/mpd-notification.c#L108

eworm-de commented 4 months ago

Can you please test with d692afcff131e6bd5f9ab8ba5bcdf825b8329228 (or artwork branch)?

eworm-de commented 4 months ago

Ping... Any chance you test this?

Fxzzi commented 4 months ago

EDIT::: Apologies, yes this seems to have solved it!!

Now I think we will need some sort of formatting options, I use this right now: image

Any way to mimic the look of the 2nd notif?

eworm-de commented 4 months ago

Formatting options are a different topic, please open a separate issue for that.