Quits after radio stream changes in active Queue

eworm-de / mpd-notification

Notify about tracks played by mpd

GNU General Public License v3.0

86 stars 23 forks source link

Quits after radio stream changes in active Queue #7

Closed Narrat closed 8 years ago

Narrat commented 8 years ago

I noticed the following behaviour: I have one set a Queue just with radio streams. And if I switch between the streams mpd-notification quits every time. With local files everything is normal aka it will be running until I clear the Queue. Can this behaviour be changed or is it due to the streams?

Setup: mpd (not started on boot; manually via systemctl --user) mpd-notification (manually from a shell after mpd is running. I did try the systemd user service, but it wasn't working the way I hoped)

eworm-de commented 8 years ago

Any terminal output? Any more information when started with -vv?

I never tried to play streams with mpd... Looks like it's time to change that. ;)

Narrat commented 8 years ago

None output at all, like a clearly visible error message

~ $ mpd-notification& [1] 29143 ~ $ [1] + done mpd-notification ~ $ mpd-notification ~ $ mpd-notification -vv mpd-notification: mpd-notification v0.7.1 (compiled: Oct 13 2015, 19:44:32) Exiting...

eworm-de commented 8 years ago

There are two possible code pathes to break the while loop and exit:

mpd-notification receives a signal and sets doexit++
mpd_run_idle_mask returns 0, which indicates an error: libmpdclient documentation

I suppose the latter is the case - otherwise you would see a message: Received signal ..., preparing exit. Probably this is a bug in libmpdclient...

Narrat commented 8 years ago

I can confirm, this is working Thanks for fixing it :)