search

eworm-de / routeros-scripts

a collection of scripts for MikroTik RouterOS
GNU General Public License v3.0
1.27k stars 285 forks source link

ADD username/password auth for ntfy #59

Closed gionag closed 5 months ago

gionag commented 5 months ago

Hello ! can you provide a way to specify username and password for ntfy ? fetch can accomodate user, pass for that.

some private ntfy instances (self-hosted) can be secured by that

thanks

eworm-de commented 5 months ago

I do not have access to that for testing.

gionag commented 5 months ago

i will test on my side and make a pull req

eworm-de commented 5 months ago

This is just basic auth, no? Wondering if giving credentials with the domain works... Can you try something like "username:password@domain"?

eworm-de commented 5 months ago

Just added some code... But without testing. Would you give it a try? You should switch to next branch, then add NtfyServerUser and NtfyServerPass to your configuration.

eworm-de commented 5 months ago

Ping... Any chance you test this?

Note to self... This is the documentation on authentication: https://docs.ntfy.sh/publish/#authentication

gionag commented 5 months ago

tested. works perfectly ! good job and nice addition.

(the more i use your scripts ecosystem more i like them, keep it up !)

eworm-de commented 5 months ago

Great, thanks for testing!