search

eworm-de / routeros-scripts

a collection of scripts for MikroTik RouterOS
GNU General Public License v3.0
1.32k stars 291 forks source link

dhcp-to-dns: add support for pool name in fqdn #8

Closed netztrip closed 4 years ago

netztrip commented 4 years ago

This adds support for pool names in the fqdn. I use it for a simple DMZ setup in my home network and would love to see it upstreamed. It works as expected for me but to be honest I understand only half the code.

eworm-de commented 4 years ago

Sounds reasonable, no idea why I did not come up with this myself. Did not yet look at the code, though - will try to find some spare time in the coming days.

Possibly the code could even drop support for the prefix. Having a pool with that name would have the same effect.

eworm-de commented 4 years ago

Not just the pool has a name, but the dhcp server itself (see column name in /ip dhcp-server). Would you be fine with that as well? I prepared my proposed changes in 4ba4edd7fe3e458787609dfb8785bce5ed0cf174.

netztrip commented 4 years ago

Sure, less work same outcome - I like it. Thanks for your efforts.

eworm-de commented 4 years ago

Closed via 2e1acc25059b9cc671a96ad648ef854a5bb29202.