enabledChanged/isEnabled and connectedChanged/isConnected + setOn/Off - Githubissues

ewowi / StarBase

Try things out

GNU General Public License v3.0

9 stars 9 forks source link

enabledChanged/isEnabled and connectedChanged/isConnected + setOn/Off #21

Closed ewoudwijma closed 1 year ago

ewoudwijma commented 1 year ago

pio.ini: enable artnet and ddp

Module.h

rename enabled to isEnabled
refactor event functions enabledChanged and connectedChanged

SysModModules

rename Modules class to SysModModules
add isConnected
mdlEnabled: check of value.size same as nrOfModules otherwise recreate
rename connected() to connectedChanged()

SysModWeb

connectedChanged: only addhandlers if isConnected (tbd: disable???)

UserModArtNet and DDP

disabled by default (in constructor)
connectedChanged commented! (as main checks if connected)

UserModE131

disabled by default (in constructor)
connectedChanged and enabledChanged call setOn and setOff (tbd setoff!)

UserModHA (not included in built yet)
disabled by default (in constructor)
connectedChanged; tbd if disconnected, and move to setOn and setOff (see E131)

ewowi commented 1 year ago

Implement model which deals with connected goes on or off and enabled goes on or off. Based on combination of a trigger function (e.g. enabledChanged) and a boolean (eg isEnabled)

Modules catches these functions and can use it to setOn or setOff their functionality.