search

ewowi / StarBase

Try things out
GNU General Public License v3.0
9 stars 9 forks source link

241 ring issues #37

Closed netmindz closed 7 months ago

netmindz commented 7 months ago

Default projection seems to fail to render some of the outer pixels using effects like octopus

ewoudwijma commented 7 months ago

Noted as well, will be dealt with when refactoring projectionAndMap function

ewoudwijma commented 7 months ago

Fixed. Circular fixture sizes too small due to rounding to floor.

To test, re generate fixtures used

@softhack007 , you also noticed this

Can you check and let me know if the issue can be closed ?

ewoudwijma commented 7 months ago

https://github.com/ewowi/StarMod/assets/1737159/678dcb6a-2104-4bd5-abe6-927a26f28552

softhack007 commented 7 months ago

To test, re generate fixtures used @softhack007 , you also noticed this Can you check and let me know if the issue can be closed ?

Hi, yes just uploaded, and all leds light up now in my "ring93". 👍

I have other problems afterwards as only "rainbow" and "solid" seem to work - fixture stays dark with other effects i've tried. maybe that's another bug.

ewoudwijma commented 7 months ago

Closed as it's confirmed to work fine now