ewowi / StarBase

Try things out
GNU General Public License v3.0
12 stars 9 forks source link

No mDNS/.local address #47

Closed Flavourdynamics closed 6 months ago

Flavourdynamics commented 7 months ago

Problem: Following the instructions to flash version 24040209 to ESP32-D0WDQ6 v4.4.6-dirty results in a generic hostname not accessible through mDNS/bonjour/.local address.

Next Steps:

ewowi commented 7 months ago

both WLED and StarMod devices show a generated mdns name. WLED can specify a name like is done in humancube.

so my proposal is that StarMod devices show the instance name as long as it is not StarMod (the default) If instance name is StarMod , then it will show star-escapedmac.

okay to implement that ?

@netmindz , any thoughts ?

netmindz commented 7 months ago

Sounds like a good plan

Flavourdynamics commented 7 months ago

With @netmindz considerations:

If the DCPC and mDNS hostnames are derived from the user specified "Name" field, there should be a mechanism to prevent invalid characters from being included into the Name field, or they should be substituted. I'm not sure if this is already part of the implementation, so disregard if so.

ewowi commented 7 months ago

Wifi hostname has now invalidcharacter removal, Mdns has ‘escapedmac’ which is macaddress without semicolon

but I propose that the instancename entered will already be cleaned from invalid characters directly (as you said) and the cleaned version will be used for ap name, hostname, mdns name etc (all the same)

ewowi commented 7 months ago

Implemented in latest StarMod (Core) commit: https://github.com/ewowi/StarMod/commit/4f12da235bcee958b74f6d932b20a5ffcf9c449c

Following the new split of StarMod (Core) and StarMod Leds: Also merged downstream to StarMod Leds

StarDocs: See https://ewowi.github.io/StarDocs/SysMod/SysModSystem/

Please test in latest StarMod Core or Leds

ewowi commented 6 months ago

Implemented and tested