Failed build creates pass

[KenwoodFox]

BUILD FAILED in 12s
Compilation Error!
GradleRIO detected this build failed due to a Compile Error (compileJava).
Check that all your files are saved, then scroll up in this log for more information.

My build failed but I still got a checkmark, what's up with that?

[ewpratten]

That is weird. Can I see the yml config you are using?

@frc5024 has had no issues with:

name: FRC Build & Test
on: [push, pull_request]

jobs:
  build:
    runs-on: ubuntu-18.04
    steps:
    - uses: actions/checkout@v2-beta
    - name: FRC Build & Test
      uses: ewpratten/FRC-actions@v1
      with:
        build_mode: 'all'

[KenwoodFox]

Sure thing!

on: [push]

jobs:
  build:
    runs-on: ubuntu-18.04
    steps:
    - uses: actions/checkout@v2
    - name: FRC Build & Test
      uses: ewpratten/FRC-actions@v1.1.1
      with:
        build_mode: 'build'

[ewpratten]

That config looks good to me, and from looking through the pipline for @FRC-1721 (where I assume you are using this), I cant seem to find anything obvious.

Maybe this was just a fluke? Occasionally @frc5024's pipelines fail for no good reason, so I'm thinking it is just something to do with GitHub and not actually the docker container.

If you continue having issues, let me know, and i'll try to re-create them

[KenwoodFox]

Tested it again with another commit and it seems to be working now? So i guess thats good :) Ill Open another issue if it continues regularly, it may have just been a fluke.

[KenwoodFox]

Issue returned, no idea why.

Run ewpratten/FRC-actions@v1.1.1
/usr/bin/docker run --name dfbf42511c82e16424abadff6c1ba69306d_0b9c25 --label 488dfb --workdir /github/workspace --rm -e INPUT_BUILD_MODE -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/1721-InfiniteRecharge/1721-InfiniteRecharge":"/github/workspace" 488dfb:f42511c82e16424abadff6c1ba69306d  "build"

Welcome to Gradle 5.0!

Here are the highlights of this release:
 - Kotlin DSL 1.0
 - Task timeouts
 - Dependency alignment aka BOM support
 - Interactive `gradle init`

For more details see https://docs.gradle.org/5.0/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
> Task :wrapper

BUILD SUCCESSFUL in 10s
1 actionable task: 1 executed
Running only build task
Downloading https://services.gradle.org/distributions/gradle-5.0-bin.zip
.................................................................................

/github/workspace/src/main/java/frc/robot/subsystems/ROS.java:90: error: cannot find symbol
> Task :compileJava FAILED
    rosTable.putData("ResetEncoders", new ResetEncoders(drivetrain));
            ^
1 actionable task: 1 executed
  symbol:   method putData(String,ResetEncoders)
Compilation Error!
  location: variable rosTable of type NetworkTable
GradleRIO detected this build failed due to a Compile Error (compileJava).
1 error
Check that all your files are saved, then scroll up in this log for more information.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 15s

It reported this as a pass.

[ewpratten]

Can I see the code?

[KenwoodFox]

Sure thing, here is the code https://github.com/FRC-1721/1721-InfiniteRecharge/tree/02505f6193520456f3ba029c96966d619e1edd46

[ewpratten]

While I am trying to figure out a fix, I am very curious how your team's system works. Do you have a co-processor handling hardware?

[ewpratten]

Take a look at this PR I made on your repo. I tested on my team's CI runner, and everything works fine (fails correctly). I think gradle is just missing a linting check in build mode, but runs it correctly in all mode.

https://github.com/FRC-1721/1721-InfiniteRecharge/pull/21

[KenwoodFox]

Thanks so much for going out of your way to create a PR I appreciate that! :) And thanks for the interest in our software! We find the Rio mostly lacking computationally, so we offload a lot of the very advanced stuff the Rio cant do (Monte Carlo localization, image processing, game logic) onto more capable hardware. I'm working on moving away from running ROS subscribers to using NT to communicate data around the robot network. We'll publish a technical binder if you're still interested later! Check out https://github.com/FRC-1721/LAPIS if you're interested in seeing the other half of our code!