search

ewust / blokus

blokus board game played over a network
0 stars 0 forks source link

Broken Unit Tests #5

Closed nslottow closed 12 years ago

nslottow commented 12 years ago

I'm not sure which commit, probably this one: https://github.com/ewust/blokus/commit/4730e3c360933787b5b6add7315bea384fe12aad but at some point when you were changing the data libraries (on September 10th) you broke all the unit tests. Can you fix them?

ppannuto commented 12 years ago

I broke them all I imagine. I've never used python's unit test framework before, and I was changing the libraries / interfaces. I really think the introduction of extensive unit testing may be pre-mature. We're still in the phase of making preliminary design decisions / implementations, and we plainly didn't have a well-enough thought out interface system at first, but I can make an effort to make them work again soon.

ppannuto commented 12 years ago

I fixed the ones that are still relevant.