search

ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.26k stars 521 forks source link

feat: Add ability to perform octet streaming #1012

Open avinayak opened 8 months ago

avinayak commented 8 months ago

I am trying to Add support for S3 Select (https://docs.aws.amazon.com/AmazonS3/latest/userguide/selecting-content-from-objects.html) in ex_aws_s3.

However, the response of this request is an octet-stream and since this request does not support Range header, we cannot execute this request like how we do ExAws.S3.download_file.

This PR is related to changes in https://github.com/ex-aws/ex_aws_s3/pull/236

avinayak commented 8 months ago

ping @bernardd

bernardd commented 3 months ago

Hi @avinayak - sincere apologies for not getting to this sooner - it slipped through the cracks and I didn't get back to it. I will do my best to get to it this week. If I recall correctly, it failed some of the CI checks when they were run (but it's taken me so long to get back to it that the logs are now gone). If you're able to have a quick look at that that would be great.

avinayak commented 3 months ago

Hi @avinayak - sincere apologies for not getting to this sooner - it slipped through the cracks and I didn't get back to it. I will do my best to get to it this week. If I recall correctly, it failed some of the CI checks when they were run (but it's taken me so long to get back to it that the logs are now gone). If you're able to have a quick look at that that would be great.

I'll fix the issues with this PR as soon as I can. Thanks for replying