search

ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.27k stars 526 forks source link

Latest version adds dependency on out of date mime package. #829

Closed JonRowe closed 2 years ago

JonRowe commented 2 years ago

Hello, the latest patch version of ex_aws adds a dependency incompatible with up to date Phoenix installs (mime is currently on 2.x not 1.x), this means people cannot upgrade to the latest due to existing dependencies. Ideally you should change mime to depend on ~> 1.2 or ~> 2.0 or if you're going to add a incompatible dependency that should be a major version bump under semver so that its flagged as "can't upgrade" correctly in mix hex.outdated

Environment

Current behaviour

mix deps.update ex_aws 
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  ex_aws 2.2.5
  mime 2.0.1

Expected behaviour

mix deps.update ex_aws 
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  mime 2.0.1
Upgraded:
  ex_aws 2.2.6
bernardd commented 2 years ago

Right - the reason mime was restricted to 1.x was because 2.x requires elixir 1.10, and ex_aws currently maintains compatibility back to 1.7. You're right, though, that ~> 1.2 or ~> 2.0 would be a better requirement. I'll fix that up.

JonRowe commented 2 years ago

Thank you, and thank you for your work maintaining this project.