Sometimes a URL may not specify a path to AWS, which in turn can cause an issue while a signature is being created for that URL.
Current Behaviour:
The following flow is executed when populating the headers
headers -> auth_headers -> signature -> get_path
In get_path's current implementation, if the path is empty, it will return a nil value (which causes a matching error further on)
For example:
Expected Behaviour:
This PR adds a small change that allows for empty paths to be sent and the signature still being created for the specified URL. Instead of returning a nil value, get_path would return "/" upon discovering an empty path
I tested my changes locally, added a unit test and also ran the automated tests (with a local DynamoDB instance running). I also ran mix format and mix dialyzer before pushing my changes.
bernardd
commented
2 years ago
Sometimes a URL may not specify a path to AWS, which in turn can cause an issue while a signature is being created for that URL.
Current Behaviour:
The following flow is executed when populating the headers
headers -> auth_headers -> signature -> get_path
In get_path's current implementation, if the path is empty, it will return a nil value (which causes a matching error further on)
For example:
Expected Behaviour:
This PR adds a small change that allows for empty paths to be sent and the signature still being created for the specified URL. Instead of returning a nil value, get_path would return "/" upon discovering an empty path
Note:
Following the contribution guide here https://github.com/ex-aws/ex_aws/blob/bdc758048042e5db86179c843fdbbd9cbd2bbd4e/CONTRIBUTING.md
I tested my changes locally, added a unit test and also ran the automated tests (with a local DynamoDB instance running). I also ran mix format and mix dialyzer before pushing my changes.