search

ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.26k stars 521 forks source link

Include service in telemetry events #886

Closed hoyon closed 2 years ago

hoyon commented 2 years ago

Exposes service in telemetry events so that it's easier to see which services are being used in our monitoring.

I'm also wondering if there's a way to expose the name of the API being used. eg GetObject or PutObject for S3.

bernardd commented 2 years ago

I'm also wondering if there's a way to expose the name of the API being used. eg GetObject or PutObject for S3.

I think you'd need an extra field in the request that was set by every service. It's certainly doable, but would be a non-trivial task (unless you can think of a more clever way).

bernardd commented 2 years ago

Looks good to me, thanks @hoyon!