search

ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.26k stars 521 forks source link

Add me-south-1 to sqs endpoints #892

Closed infinityfye closed 2 years ago

infinityfye commented 2 years ago

Hello and sorry for the impromptu request

We were testing a service for a couple of days and as we are using elasticmq locally we didn't run into this. However, as we deployed to our development environment we ran into this:

** (RuntimeError) sqs not supported in region me-south-1 for partition aws
(ex_aws 2.3.3) lib/ex_aws/config/defaults.ex:175: ExAws.Config.Defaults.fetch_or/3
(ex_aws 2.3.3) lib/ex_aws/config/defaults.ex:158: ExAws.Config.Defaults.do_host/3
(ex_aws 2.3.3) lib/ex_aws/config/defaults.ex:89: ExAws.Config.Defaults.get/2
(ex_aws 2.3.3) lib/ex_aws/config.ex:70: ExAws.Config.build_base/2
(ex_aws 2.3.3) lib/ex_aws/config.ex:43: ExAws.Config.new/2
(ex_aws 2.3.3) lib/ex_aws.ex:73: ExAws.request/2

So, I'm proposing adding the me-south-1 region to the sqs endpoints

Environment

Erlang 25.0.2
Elixir 1.13.4 (compiled with Erlang/OTP 25), 
ExAws version 2.3.3
HTTP client version. IE for hackney do mix deps | grep hackney: hackney 1.18.1

Current behavior

SQS queues on me-south-1 region won't work

Expected behavior

SQS queues on me-south-1 region should work

bernardd commented 2 years ago

Hi @infinityfye - no need to apologise, this is exactly what PRs are for, and impromptu requests are what make open source work :) Thanks!