ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.26k stars 521 forks source link

Fix happy path-only http client doc #923

Closed adworse closed 1 year ago

adworse commented 1 year ago

Thank you for all your hard work! Below is a slight docs improvement.

A current example of custom ExAws.Request.HttpClient behaviour implementation always packs the response in {:ok, result} tuple, which only works for happy path and breaks if the underlying client returns an error.

The proposed example correctly packs errors in the error tuple that ExAws.Request.request_and_retry/7 function is expecting.

bernardd commented 1 year ago

Great, thanks very much @adworse