search

ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.26k stars 521 forks source link

Add request and response to telemetry #935

Closed Cantido closed 1 year ago

Cantido commented 1 year ago

I'm working on a library to adapt ExAws's telemetry into OpenTelemetry data. OpenTelemetry actually has a set of recommendations for which data to include here: Semantic conventions for AWS SDK. If ExAws can include the request and response bodies in its telemetry, the adapter library can include all the data that OpenTelemetry requests.

The PR for that adapter library is here: https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/152.

bernardd commented 1 year ago

Looks great, thanks @Cantido. Would you be able to run mix format over it, and then we'll get it merged. Cheers.

Cantido commented 1 year ago

All set!

Edit: forgot about the test file, I just got that formatted too.

bernardd commented 1 year ago

Thanks @Cantido!

Cantido commented 1 year ago

Would it be possible to cut a release for this? I'd love to get this into the OpenTelemetry adapter I'm working on.

bernardd commented 1 year ago

It is, and I was just about to, however due to a bit of a screwup on my part I need to get hold of some code at home (which I utterly failed to push to github), and I'm away most of this week. I'll get it done for you ASAP though.

Cantido commented 1 year ago

Hey no worries! Thank you so much for supporting this library!