ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir
https://hex.pm/packages/ex_aws
MIT License
1.26k stars 521 forks source link

S3 objects with `?` in key cannot be queried #944

Open novaugust opened 1 year ago

novaugust commented 1 year ago

Environment

Current behavior

could be similar to #546 , where special s3 path parsing breaks reaching an object

s3 objects with ? in the key are unreachable from ex_aws

It's true that S3's key naming strongly recommends against including ? in keys, but it allows and handles them all the same, and they're still accessible via its cli. Alas, in our case the mistake has already been made :)

Expected behavior

s3 objects with ? would ideally be reachable

bernardd commented 1 year ago

Happy to look at a PR for this if there's a sane way to fix it (or even if there's a less-sane way that requires a config option to enable).