The get_caller_identity test was not passing as this made a call to AWS. If this is an integration test, then we would either make this clearer and add documentation how this test can pass when developing with this package.
I have made the test follow the same format as the other tests to make the test pass. This tests the params of the query it will call.
We could look at mocking the request response, to make the test pass without setup, but that seemed a step too far for now.
Thoughts and ideas on this suggestion are appreciated.
vanetix
commented
4 years ago
The get_caller_identity test was not passing as this made a call to AWS. If this is an integration test, then we would either make this clearer and add documentation how this test can pass when developing with this package.
I have made the test follow the same format as the other tests to make the test pass. This tests the params of the query it will call.
We could look at mocking the request response, to make the test pass without setup, but that seemed a step too far for now.
Thoughts and ideas on this suggestion are appreciated.