ex-aws / ex_aws_sts

13 stars 31 forks source link

Suggestion for JSON authentication responses #8

Open samfrench opened 5 years ago

samfrench commented 5 years ago

Environment

Current behavior

Currently, the STS responses are in XML which is then parsed with SweetXML.

https://github.com/ex-aws/ex_aws_sts/blob/master/lib/ex_aws/sts/parsers.ex

When adding an accept header of "application/json" to the request, a JSON response is returned from the assume_role service. I am not sure if this is applicable to all of the endpoints used in this package.

Expected behavior

Is there any thought about using JSON, or allowing JSON to be requested? This would need another parser as these are all XML based, but this would allow for the dependency of SweetXML to only be used when the service only provides XML.

koozdra commented 4 years ago

Could you point to some documentation of json responses? I'm not seeing it in the AWS documentation.