search

ex0nuss / Remote-Wake-Sleep-On-LAN-Docker

A docker image of sciguy14/Remote-Wake-Sleep-On-LAN-Server
GNU General Public License v3.0
34 stars 16 forks source link

The 'RWSOLS_COMPUTER_NAME' variable does not support spaces on its values #6

Closed SmartPhoneLover closed 2 years ago

SmartPhoneLover commented 2 years ago

DESCRIPTION When I add a device name that contains spaces on its name, the container web interface fails to start when the container starts. For example: if a a device name, like "My Server", not web interface is shown (blank); but, if I add it like "My-Server" or "MyServer" the web interface loads as expected.

EXPECTED The web interface should be shown, as normally.

ex0nuss commented 2 years ago

Hi, thank you for opening up this issue and informing me about this bug.

The space gets piped correctly into the container, but the entrypoint-script formats it's wrong. The entrypoint-script creates the entire config-files and starts apache2 afterwards. It uses an sed-command.

Unfortunately I don't have the time to look into this deeper right know. Please use an hyphen oder underscore for now. I add this information into the README too ;)

SmartPhoneLover commented 2 years ago

Ok, no problem. Thank you for replying ;)