ex208 / Positive_Selection_Pipeline

0 stars 0 forks source link

File naming conventions #6

Open widdowquinn opened 6 years ago

widdowquinn commented 6 years ago

In the bin directory of commit 16765fd there are files with the same names, but numeric suffixes. For example:

The purpose of this is not clear. An aim of version control is to have, for example, a single piece of code for a script whose changes are tracked in the VC system, avoiding the 'need' to label files with versioning suffixes.

Is it possible to remove one or other of these (and drop the suffix) to meet this expectation?

ex208 commented 6 years ago

Not quite sure yet how I can do this. The reason I have got two different back translation scripts is because they apply to different type of datasets (in this case the split and unsplit CAZy families with different degree of complexity) and I use them for the above respectively. Maybe in this case a more appropriate naming is more appropriate. However, if you do have a suggestion on how I could keep one of them but being able to use it for two different purposes I would be happy to look into

widdowquinn commented 6 years ago

I think the best way to solve this will be to abstract out what both files do/the code as a whole does so that a single file can handle both split and unsplit families. That will require a more detailed review.