search

exAspArk / batch-loader

:zap: Powerful tool for avoiding N+1 DB or HTTP queries
https://engineering.universe.com/batching-a-powerful-way-to-solve-n-1-queries-every-rubyist-should-know-24e20c6e7b94
MIT License
1.04k stars 52 forks source link

Fixed deprectation warning from using ruby 2.7.1 #71

Closed dub-squared closed 3 years ago

dub-squared commented 4 years ago

When using Ruby 2.7.1, the gem triggers a Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call deprecation warning. This PR resolves the warning. The specs complete without error under Ruby 2.6.4 and 2.7.1

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d19d49b45a933028566d22a07d6afebda02fad43 on Workstream-App:master into 94ffd9d7d942b388382d6872f3d29634cefd41f0 on exAspArk:master.

stanhu commented 3 years ago

@exAspArk With Ruby v3.0 out now, I think this pull request could use some attention? I'm seeing this warning fail on builds now.

berkos commented 3 years ago

👋 It would be great if we could get this out in a gem release. 🙏

exAspArk commented 3 years ago

Thanks a lot! 💛 And sorry for the delayed response. I'll try to adjust the TravisCI config to add the latest Ruby versions and create a new release.

exAspArk commented 3 years ago

I released these changes in v2.0.1 🎉