search

exAspArk / graphql-guard

Simple authorization gem for GraphQL :lock:
MIT License
471 stars 36 forks source link

Use ruby syntax highlighted code blocks #29

Closed vfonic closed 5 years ago

vfonic commented 5 years ago

I understand that the <pre> blocks might have been done on purpose, however, I find it much easier to read syntax highlighted blocks and I thought other developers might as well.

But I can see the benefit of being able to bold specific changes (although there's not a lot of code in there, so maybe syntax highlighting after all? :D ), feel free to reject this PR.

Thanks!

EDIT: You can preview the new readme here: https://github.com/exAspArk/graphql-guard/blob/f4184b0a3a09121dd858a17929b3b88919ea23a9/README.md

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f4184b0a3a09121dd858a17929b3b88919ea23a9 on vfonic:patch-1 into fb2ebb32246373c8ea9e3252d5d668a25db13f32 on exAspArk:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f4184b0a3a09121dd858a17929b3b88919ea23a9 on vfonic:patch-1 into fb2ebb32246373c8ea9e3252d5d668a25db13f32 on exAspArk:master.

ghost commented 5 years ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

vfonic commented 5 years ago

@exAspArk did you get the chance to look at this? Thanks!

exAspArk commented 5 years ago

Hey @vfonic,

Yeah, I intentionally wanted to highlight the important parts of the code examples. Unfortunately, GitHub doesn't allow enabling syntax highlighting with highlighting some pieces of the code: increasing text width, underlining, configure opacity, etc. In this particular case, I prefer highlighting specific parts of the code over general syntax highlighting.

Thank you for opening the PR though! 🙌