search

exAspArk / graphql-guard

Simple authorization gem for GraphQL :lock:
MIT License
471 stars 36 forks source link

Update README.md with details for whitelisting introspection queries. #6

Closed stanishev closed 6 years ago

stanishev commented 6 years ago

I've tried to keep the changes to a minimum, while also keeping the new section clear. I didn't create a separate section as you suggested, because I thought that the introspection bit makes sense only in the context of using a GraphQLPolicy object (so policy 4), so it seemed natural to append it to the existing section.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1e869748b68d5df225a639e76ec4e545a5f860ef on stanishev:master into fafa6e4ed279e5faec48f38f1fb27276ff95d4d3 on exAspArk:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4bb25c4d5eae0db27b4da8462db59ad2406684b6 on stanishev:master into fafa6e4ed279e5faec48f38f1fb27276ff95d4d3 on exAspArk:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 79cc2fafcc9085704c83fba7da08511d24d5a749 on stanishev:master into fafa6e4ed279e5faec48f38f1fb27276ff95d4d3 on exAspArk:master.

exAspArk commented 6 years ago

@stanishev thank you so much for contributing! 🙌

image

I squashed your commits and merged the PR manually https://github.com/exAspArk/graphql-guard/commit/ac7285e2587e99ea2d00518dd951c875a9eb9188. Closed the https://github.com/exAspArk/graphql-guard/issues/4.

ghost commented 6 years ago

Can you release this in 1.0.1 please?

ghost commented 6 years ago

I tried with the master branch in my Gemfile but it still doesn't work: https://github.com/exAspArk/graphql-guard/issues/7