Origin/issue 175 - Githubissues

exa-analytics / exa

The exa framework for data management, processing, and visualization

https://exa-analytics.github.io/exa

Apache License 2.0

2 stars 10 forks source link

Origin/issue 175 #178

Closed avmarchenko closed 4 years ago

avmarchenko commented 4 years ago

Closes #175

A few questions about this PR:

I'd like to migrate all of the tests into the test dir - that way tests aren't packaged with the source dist itself.
Right now it's building on py 36-38 inclusive on linux and windows - should we add osx?
I should probably update badges for the builds and the code inspection and coverage (unittest coverage) report
What else am I missing?

tjduigna commented 4 years ago

If I remember well, historically the osx CI pipelines have been a pain. We could support it but if we move more towards docker there may be less need to support a complex CI matrix.

Updating badges makes sense to me. That and if we missed anything on the CI pipeline it should become apparent when we're using it.

I notice appveyor is running "pytest test" but travis just runs "pytest". I suppose this covers both cases for now but once we move everything into test/ we can be explicit.

avmarchenko commented 4 years ago

Updated to make the tests both pytest test, updated badges, put in a request to reactivate codacy checks, migrated the pytest tests.