exa-analytics / exatomic

A unified platform for theoretical and computational chemists
https://exa-analytics.github.io/exatomic
Apache License 2.0
19 stars 12 forks source link

ADF parsers #159

Closed herbertludowieg closed 5 years ago

herbertludowieg commented 5 years ago

Is your feature request related to a problem? Please describe. I think it would be a good idea to have some parsers implemented for ADF calculations of NMR shielding tensors since there is a lot of data to be sifted through.

Describe the solution you'd like I think it'd be good if we have some flexible methods that can be useful in most NMR calculations. This would extend to spin-spin coupling tensors as they are part of the same calculations.

Additional context I have been going back and forth in determining the best way to implement this. Since ADF has the ability to restart the calculations from a TAPE10 file, I'm leaning towards having the parsers separate from the exatomic.adf.output.Output code and in the exatomic.adf.nmr.output.Output. My reasoning for this are the following:

I think this will mark an important point in how the ADF data parsing will proceed in the future, so I really would like to take the time to go through this slowly so we do not have to do a re-write down the line. I have attached an output that I will use as a test case for the code. pf3-nmr-b3lyp.txt

herbertludowieg commented 5 years ago

I would also like add parsing frequency and gradient data to this issue. I want to also generalize the atom parsing so that we can extract the frames from a geometry optimization.