search

exa-analytics / exatomic

A unified platform for theoretical and computational chemists
https://exa-analytics.github.io/exatomic
Apache License 2.0
19 stars 12 forks source link

Exhibition widget and a more sane repr for closed UniverseWidget #200

Closed tjduigna closed 1 year ago

tjduigna commented 4 years ago

Hey I saw you assign #192 to me, thanks for reminding me about this. There are 3 open issues with this MR:

  1. The new widget has a kludge for sizing the renderer. The method still uses offsetHeight rather than canvas height but the growing/shrinking widget is actually related to the element offsetHeight instability during kernel reset. Instead, it makes an explicit check whether the widget is connected to the kernel before attempting to resize.
  2. The selenium script throws a timeout exception in the travis build. Not so much a workaround, more of a punt. The test script will handle this exception. It is still a useful development test script and brings us much closer to CI testing for widgets.
  3. The CI pipeline does not work for both linux and macos right now. Parametrizing both chrome and firefox driver installation on both mac and linux is complete. This at least makes it easier to resolve 2 in the future.
tjduigna commented 4 years ago

I like the idea of sending a message back to the kernel on promise fulfillment. And yes presumably we can set up a selenium test to run in CI. I will see what it will take to get some of that going as part of this PR.

avmarchenko commented 1 year ago

Closing as stale - will reopen as appropriate.