search

exa04 / cyma

Visualizers for nih-plug UIs made using VIZIA.
https://exa04.github.io/cyma/book
Mozilla Public License 2.0
35 stars 1 forks source link

WIP Histogram #54

Closed magnetophon closed 6 months ago

magnetophon commented 6 months ago

As requested in the chat, a PR for this WIP code.

magnetophon commented 6 months ago

Thanks for the feedback and your great help! I've implemented all your suggestions, from both here and our chats. Let me know if I missed anything.

Next steps, as far as I can tell, are improving the decay scaling and making it adjustable. Should I implement FillModifiers? If yes, I'd need some guidance. :)

Anything else?

exa04 commented 6 months ago

I just tried your histogram example and it seems to work really well. Awesome!

Should I implement FillModifiers?

You can just leave that up to me :)

magnetophon commented 6 months ago

Cool, thanks!

magnetophon commented 6 months ago

OK, done.

Shall I make it all into a single commit?

exa04 commented 6 months ago

A single commit? I would just merge this PR

magnetophon commented 6 months ago

Most of my PR's have been for nixpkgs, and they trained me into that way of thinking. :sweat_smile:

exa04 commented 6 months ago

Oh, I see. Well let's get this merged :)