exactly / app

web application for interacting with exactly protocol.
https://app.exact.ly
Other
20 stars 11 forks source link

installments: withdraw modal max crash the app #1391

Closed alexx855 closed 5 months ago

alexx855 commented 5 months ago

Hello there!

I've found a 🐛 while using the app:

How to reproduce: In /dashboard, click withdraw button in Your Deposits > Fixed Interest Rate > ETH image In the modal, then i click the MAX button and the app crash. image

Short video: https://github.com/exactly/app/assets/1799851/7f6db27f-56e1-4a3d-9a1b-1760c23d15cd

In the console i get: RangeError: Division by zero app.exact.ly-1714729117568.log

After sorting the RangeError: Division by zero error, i got the another one that also crashed the app: ALREADY_MATURED

alexx855 commented 5 months ago

I've submitted a PR #1392 for this issue that prevents the app from crashing, although I'm not certain it's the correct resolution. Perhaps this could be addressed or relocated to exactly/lib.

alexx855 commented 5 months ago

Fixed in a01461a1a1a7ca2930c36dda462e290cbd8bac9a