Closed tearsofphoenix closed 6 years ago
Looks better (though it would be much nicer to actually check for readpassphrase presence, and not rely on the (false) presumption that "all unixes have bsd/readpassphrase.h".
Anyway, I just noticed that the resulting ccr
is compiled without crypto++ support (thus, no SHA-family hashes etc.). Probably not a problem but it would be nice to also include the check.
@exaexa now, add real check for both libraries. No need to check on mac because it has
readpassphrase.h
. Tested on macOS High Sierra 10.13.2 & Ubuntu 16.04.
OK, now it works just right! Accepted&thanks!
Hi,
Thanks for the contribution. There are 2 problems:
First, the produced executable should be named
ccr
notcodecrypt
.Second, would it also be possible to check for
readpassphrase
function from libBSD (and setting flags accordingly) so that the compile warning about defaulting togetpass()
is not produced?This:
You may find the relevant logic here: https://github.com/exaexa/codecrypt/blob/master/configure.ac#L58-L73
Anyway, please continue working rebased to 'cmake' master of codecrypt repo.