exaexa / codecrypt

Post-quantum cryptography tool (THIS REPOSITORY IS ONLY A MIRROR OF THE MAIN ONE, PLEASE DO NOT FILE BUGS HERE)
https://gitea.blesmrt.net/exa/codecrypt
GNU Lesser General Public License v3.0
308 stars 40 forks source link

crypto++ header location #8

Closed ghost91- closed 8 years ago

ghost91- commented 8 years ago

The crypto++ headers are placed in the folder "/include/cryptopp" (at least the make script of crypto++ and arch linux place it at that directory). The codecrypt currently assumes it to be in the folder "/include/crypto++".

exaexa commented 8 years ago

I will try to use pkgconfig for discovering the location of the headers. Please workaround with explicit ./configure CPPFLAGS=... in the meantime.

exaexa commented 8 years ago

The thing seems to be put into include/crypto++ folder in debian and some other distros. What output do you get from pkg-config libcrypto++ --cflags ?

ghost91- commented 8 years ago

pkg-config libcrypto++ --cflags returns nothing on my machine.

exaexa commented 8 years ago

I was hoping it would return the correct crypto++ include path. Can you think of some other good method to portably detect the path to headers? (I'm not sure if "try this else that" approach would fit in autotools logic)

ghost91- commented 8 years ago

I just had a look at amule, which also uses crypto++, in order to see, what they do to solve this issue. They simply check for both directories: https://github.com/amule-project/amule/blob/master/m4/cryptopp.m4

exaexa commented 8 years ago

Just realized that debian adds compatibility symlink cryptopp->crypto++. Asking arch guys to do the same would be nice.

Nevermind, I added a test that should handle both cases accordingly, please try the latest git dbce46b48a

I hope there are no more possibilities where the headers could go.

ghost91- commented 8 years ago

Thanks, it works fine now. I guess this can be closed.

exaexa commented 8 years ago

Cool, thanks for report.