exaexa / scattermore

very fast scatterplots for R
https://exaexa.github.io/scattermore/
GNU General Public License v3.0
238 stars 7 forks source link

alpha(coords$colour, coords$alpha) not found #4

Closed roman-tremmel closed 4 years ago

roman-tremmel commented 4 years ago

I want to use your function scattermore::geom_scattermore() in my function build into a new R package. After a clean install, I recieve following error:

Fehler in alpha(coords$colour, coords$alpha) : 
    konnte Funktion "alpha" nicht finden 

Which means that the ggplot2::alpha function is not found. After loading ggplot2 library, the error is gone. But I don't like to load ggplot in my package using library or require. Can you fix that for instance in line 209?

exaexa commented 4 years ago

Hello! Thank you for reporting, it seems like I forgot to prefix the function with package prefix so that it works even without explicit library import.

Can you try with the latest commit from git master? (eg. devtools::install_github('exaexa/scattermore', dependencies=F))

roman-tremmel commented 4 years ago

perfect. Works now as expected.

exaexa commented 4 years ago

Great, thanks again! Can you (for now) use the version from git, or should I try to push a fixed release to CRAN asap?

roman-tremmel commented 4 years ago

I will use the git version. Since my package is more an internal one it's ok for now. Thanks for the fast response and the nice package.