example42 / psick

Puppet Systems Infrastructure Construction Kit: The control-repo
http://www.example42.com
Apache License 2.0
656 stars 183 forks source link

Rename Gitlab CI variable CI_BUILD_REF_NAME -> CI_COMMIT_REF_NAME #273

Closed karolisc closed 4 years ago

karolisc commented 5 years ago

Gitlab CI variable CI_BUILD_REF_NAME is deprecated. Rename it to CI_COMMIT_REF_NAME as in future releases it will be removed.

Note: Starting with GitLab 9.0, we have deprecated the $CIBUILD* variables. You are strongly advised to use the new variables as we will remove the old ones in future GitLab releases.

Reference:
https://docs.gitlab.com/ee/ci/variables/#gitlab-90-renaming

Affected files:
psick.gitlab-ci.yml psick\gitlab.gitlab-ci.yml-integration psick\gitlab.gitlab-ci.yml-with-fakes

tuxmea commented 5 years ago

@alvagante which version of gitlab are we running internally? Can we just change all occurrences of the deprecated variable to the new one?

alvagante commented 5 years ago

@tuxmea yes, we use the latests

alvagante commented 4 years ago

Occurrences removed also from also gitlab-ci.yaml files in https://github.com/example42/psick/commit/2d1bd46f550595e5b85ea2ef7c58ce2c945bd877 closing the ticket

BaseMax commented 9 months ago

thanks