example42 / puppet-apache

Apache Puppet Module
http://www.example42.com
Other
42 stars 79 forks source link

syntax error in conditional #96

Closed ghost closed 8 years ago

ghost commented 8 years ago

Expected Behavior

that it doesn't error

Actual Behavior

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Resource type not found: SLES at /etc/puppetlabs/code/environments/master/modules/apache/manifests/init.pp:308:5 on node xxxx

Steps to Reproduce the Problem

Run module against puppet 4

Specifications

Please add this info:

Version of Puppet: and of the module

# puppet --version
4.5.1

Module version: v2.1.12 The relevant Puppet code and eventually Hiera data Nebenbei: eventually ist nicht das deutsche eventuell. eventually heisst irgendwann. Besser: "optionally"

   ### Calculation of variables that dependes on arguments
   $vdir = $::operatingsystem ? {
     /(?i:Ubuntu|Debian|Mint)/ => "${apache::config_dir}/sites-available",
-    SLES                      => "${apache::config_dir}/vhosts.d",
+    'SLES'                    => "${apache::config_dir}/vhosts.d",
     default                   => "${apache::config_dir}/conf.d",
   }
alvagante commented 8 years ago

Fixed with #97